Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754812AbYJWI4X (ORCPT ); Thu, 23 Oct 2008 04:56:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751572AbYJWI4J (ORCPT ); Thu, 23 Oct 2008 04:56:09 -0400 Received: from anchor-post-36.mail.demon.net ([194.217.242.86]:4445 "EHLO anchor-post-36.mail.demon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbYJWI4I (ORCPT ); Thu, 23 Oct 2008 04:56:08 -0400 Message-ID: <49003C35.1090301@lougher.demon.co.uk> Date: Thu, 23 Oct 2008 09:56:21 +0100 From: Phillip Lougher User-Agent: Thunderbird 2.0.0.6 (X11/20071008) MIME-Version: 1.0 To: Geert Uytterhoeven CC: akpm@linux-foundation.org, linux-embedded@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, tim.bird@am.sony.com Subject: Re: Subject: [PATCH 12/16] Squashfs: header files References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 46 Geert Uytterhoeven wrote: > On Fri, 17 Oct 2008, Phillip Lougher wrote: >> +#ifdef SQUASHFS_TRACE >> +#define TRACE(s, args...) printk(KERN_NOTICE "SQUASHFS: "s, ## args) >> +#else >> +#define TRACE(s, args...) {} >> +#endif > > Just use > > #define TRACE(s, args...) pr_debug("SQUASHFS: "s, ## args) OK. >> + >> +#define WARNING(s, args...) printk(KERN_WARNING "SQUASHFS: "s, ## args) > ^^^^^^^^^^^^^^^^ > pr_warning( > OK. > > SQUASHFS_MKFLAGS() isn't used by the kernel, only by the tools (mksquashfs)? > Only used by mksquashfs. I pulled out the user-space only stuff into a separate include, but must have missed this one. >> +/* meta index cache */ >> +#define SQUASHFS_META_INDEXES (SQUASHFS_METADATA_SIZE / sizeof(unsigned int)) > ^^^^^^^^^^^^ > I was wondering whether a meta index is an `unsigned int' or an `__le32', but I > couldn't find it easily. > Unsigned int, it's used internally by the index cache code (file.c). It works out how many block indexes can fit into one compressed metadata block. Phillip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/