Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755347AbYJWJDS (ORCPT ); Thu, 23 Oct 2008 05:03:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752544AbYJWJC7 (ORCPT ); Thu, 23 Oct 2008 05:02:59 -0400 Received: from ecfrec.frec.bull.fr ([129.183.4.8]:60995 "EHLO ecfrec.frec.bull.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751826AbYJWJC5 (ORCPT ); Thu, 23 Oct 2008 05:02:57 -0400 Message-ID: <49003019.40904@bull.net> Date: Thu, 23 Oct 2008 10:04:41 +0200 From: Benjamin Thery User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: "Eric W. Biederman" Cc: "Serge E. Hallyn" , netdev , Dave Miller , Greg Kroah-Hartman , Al Viro , Daniel Lezcano , linux-kernel@vger.kernel.org, Tejun Heo , Denis Lunev , Linux Containers Subject: Re: [PATCH] netns: Coexist with the sysfs limitations References: <20081022152144.351965414@theryb.frec.bull.fr> <20081022212124.GA9910@us.ibm.com> In-Reply-To: <20081022212124.GA9910@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2354 Lines: 77 Serge E. Hallyn wrote: > Quoting Eric W. Biederman (ebiederm@xmission.com): >> To make testing of the network namespace simpler allow >> the network namespace code and the sysfs code to be >> compiled and run at the same time. To do this only >> virtual devices are allowed in the additional network >> namespaces and those virtual devices are not placed >> in the kobject tree. >> >> Since virtual devices don't actually do anything interesting >> hardware wise that needs device management there should >> be no loss in keeping them out of the kobject tree and >> by implication sysfs. The gain in ease of testing >> and code coverage should be significant. >> >> I.e. people running distributions that make it next to >> impossible to boot without sysfs should at be able to >> boot a test kernel now. >> >> Plus no ABIs are harmed with this patch. >> Signed-off-by: Eric W. Biederman > > Duh. > > Tested-by: Serge Hallyn > Acked-by: Serge Hallyn Oh, this patch is short, clean, and the limitation introduced isn't too annoying for testing netns right now. At least, my proposal provoked some reactions :) BTW, there's a second limitation with your patch: we can't rename the net devices in the additional network namespaces. In net/core/dev.c, dev_change_name() fails: call to device_rename() return an (expected) -EINVAL error. Maybe we should add a test on the net to only call it in init_net? rollback: - err = device_rename(&dev->dev, dev->name); - if (err) { - memcpy(dev->name, oldname, IFNAMSIZ); - return err; + if (net == &init_net) { + err = device_rename(&dev->dev, dev->name); + if (err) { + memcpy(dev->name, oldname, IFNAMSIZ); + return err; + } } Otherwise, Acked-by: Benjamin Thery Thanks, Benjamin > > Thanks, Eric! Thanks, Benjamin! > > -serge > > -- B e n j a m i n T h e r y - BULL/DT/Open Software R&D http://www.bull.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/