Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755080AbYJWJ6S (ORCPT ); Thu, 23 Oct 2008 05:58:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752008AbYJWJ6H (ORCPT ); Thu, 23 Oct 2008 05:58:07 -0400 Received: from ns.suse.de ([195.135.220.2]:49159 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751873AbYJWJ6G (ORCPT ); Thu, 23 Oct 2008 05:58:06 -0400 Date: Thu, 23 Oct 2008 13:58:02 +0200 Message-ID: From: Takashi Iwai To: FUJITA Tomonori Cc: svens@stackframe.org, joerg.roedel@amd.com, mingo@elte.hu, linux-kernel@vger.kernel.org Subject: Re: swiotlb_alloc_coherent: allocated memory is out of range for device In-Reply-To: References: <20081022221321J.fujita.tomonori@lab.ntt.co.jp> <20081023113618T.fujita.tomonori@lab.ntt.co.jp> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 910 Lines: 26 At Thu, 23 Oct 2008 07:22:09 +0200, I wrote: > > > The current dma_alloc_coherent (asm-x86/dma-mapping.h) handles the gfp > > flags in the exact same way as the old dma_alloc_coherent > > (pci-dma.c). Neither sets GFP_DMA even if coherent_dma_mask is > > 24bits. The old code is fine because of the GFP_DMA retry > > mechanism. But if coherent_dma_mask is 24bits, there is no point to go > > into the GFP_DMA retry mechanism. We should use GFP_DMA in the first > > place. > > > > How about the following patch? > > I'll give it a try later (the machine is in my office). The patch seems working fine. Thanks! Tested-by: Takashi Iwai Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/