Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754083AbYJWKQX (ORCPT ); Thu, 23 Oct 2008 06:16:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751873AbYJWKQO (ORCPT ); Thu, 23 Oct 2008 06:16:14 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:36677 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751826AbYJWKQN (ORCPT ); Thu, 23 Oct 2008 06:16:13 -0400 Date: Thu, 23 Oct 2008 12:15:57 +0200 From: Ingo Molnar To: Takashi Iwai Cc: FUJITA Tomonori , svens@stackframe.org, joerg.roedel@amd.com, linux-kernel@vger.kernel.org, "H. Peter Anvin" Subject: Re: swiotlb_alloc_coherent: allocated memory is out of range for device Message-ID: <20081023101557.GA30302@elte.hu> References: <20081022221321J.fujita.tomonori@lab.ntt.co.jp> <20081023113618T.fujita.tomonori@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00,DNS_FROM_SECURITYSAGE autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.0 DNS_FROM_SECURITYSAGE RBL: Envelope sender in blackholes.securitysage.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1087 Lines: 31 * Takashi Iwai wrote: > At Thu, 23 Oct 2008 07:22:09 +0200, > I wrote: > > > > > The current dma_alloc_coherent (asm-x86/dma-mapping.h) handles the gfp > > > flags in the exact same way as the old dma_alloc_coherent > > > (pci-dma.c). Neither sets GFP_DMA even if coherent_dma_mask is > > > 24bits. The old code is fine because of the GFP_DMA retry > > > mechanism. But if coherent_dma_mask is 24bits, there is no point to go > > > into the GFP_DMA retry mechanism. We should use GFP_DMA in the first > > > place. > > > > > > How about the following patch? > > > > I'll give it a try later (the machine is in my office). > > The patch seems working fine. Thanks! > > Tested-by: Takashi Iwai thanks guys - i've queued it up in tip/core/urgent and will send a pull request to Linus later today. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/