Date: Thu, 23 Oct 2008 06:33:39 -0400
From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Greg KH <greg@kroah.com>
Cc: Greg KH <gregkh@suse.de>, "Theodore Ts'o" <tytso@mit.edu>,
       Zwane Mwaikambo <zwane@arm.linux.org.uk>, torvalds@linux-foundation.org,
       Eugene Teo <eteo@redhat.com>, Justin Forbes <jmforbes@linuxtx.org>,
       linux-kernel@vger.kernel.org, Chris Wedgwood <reviews@ml.cw.f00f.org>,
       Domenico Andreoli <cavokz@gmail.com>,
       Randy Dunlap <rdunlap@xenotime.net>, Willy Tarreau <w@1wt.eu>,
       Michael Krufky <mkrufky@linuxtv.org>, alan@lxorguk.ukuu.org.uk,
       Chuck Ebbert <cebbert@redhat.com>, Dave Jones <davej@redhat.com>,
       akpm@linux-foundation.org, Jake Edge <jake@lwn.net>,
       Chuck Wolber <chuckw@quantumlinux.com>, stable@kernel.org,
       Rodrigo Rubira Branco <rbranco@la.checkpoint.com>
Subject: Re: [stable] [patch 00/17] 2.6.27-stable review
Message-ID: <20081023063339.11c99044@zod.rchland.ibm.com>
In-Reply-To: <20081023045345.GB6949@kroah.com>
References: <20081018183334.GA14035@suse.de>
	<20081023010126.GB30920@zod.rchland.ibm.com>
	<20081023045345.GB6949@kroah.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2504
Lines: 59

On Wed, 22 Oct 2008 21:53:45 -0700
Greg KH <greg@kroah.com> wrote:

> On Wed, Oct 22, 2008 at 09:01:26PM -0400, Josh Boyer wrote:
> > On Sat, Oct 18, 2008 at 11:33:34AM -0700, Greg KH wrote:
> > >This is the start of the stable review cycle for the 2.6.27.3 release.
> > >There are 17 patches in this series, all will be posted as a response
> > >to this one.  If anyone has any issues with these being applied, please
> > >let us know.  If anyone is a maintainer of the proper subsystem, and
> > >wants to add a Signed-off-by: line to the patch, please respond with it.
> > >
> > >These patches are sent out with a number of different people on the
> > >Cc: line.  If you wish to be a reviewer, please email stable@kernel.org
> > >to add your name to the list.  If you want to be off the reviewer list,
> > >also email us.
> > >
> > >Responses should be made by Wed, October 22, 2008 19:00:00 UTC.
> > >Anything received after that time might be too late.
> > 
> > OK, I realize I'm late.  Apologies in advance for that.
> > 
> > I don't see how patches 3, 16, and 17 really fit into the "stable"
> > rules.  None of them:
> > 
> > "... fix a problem that causes a build error (but not for things
> >  marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
> >  security issue, or some "oh, that's not good" issue.  In short,
> >  something critical."
> > 
> > So, are we being a bit more lax on the requirements for the
> > -stable kernels and I missed the memo, or?
> 
> Huh?
> 
> Patch 3:
> 	Driver core: Fix cleanup in device_create_vargs().
> solves a memory leak on an error path that has every opportunity to
> happen in the driver core.  Do you think this is not a real bug?

Grr..  Typo on my part.  Patch 4 is the one I originally meant:
"Driver Core: Clarify device cleanup." It changes nothing but
comments.  I don't think it's a big deal at all, but are documentation
changes also allowed now?

> Patch 16 and 17 add new device ids, something that we started allowing
> in -stable trees a number of major releases ago.  You missed the memo
> for that one :)
> 
> Perhaps we need to add it to the file
> Documentation/stable_kernel_rules.txt, anyone care to send a patch?

Will do as soon as I get an answer to the question above.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/