Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756194AbYJWPov (ORCPT ); Thu, 23 Oct 2008 11:44:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752469AbYJWPoj (ORCPT ); Thu, 23 Oct 2008 11:44:39 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:32899 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752424AbYJWPoh (ORCPT ); Thu, 23 Oct 2008 11:44:37 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Benjamin Thery Cc: "Serge E. Hallyn" , netdev , Dave Miller , Greg Kroah-Hartman , Al Viro , Daniel Lezcano , linux-kernel@vger.kernel.org, Tejun Heo , Denis Lunev , Linux Containers References: <20081022152144.351965414@theryb.frec.bull.fr> <20081022212124.GA9910@us.ibm.com> <49003019.40904@bull.net> Date: Thu, 23 Oct 2008 08:40:09 -0700 In-Reply-To: <49003019.40904@bull.net> (Benjamin Thery's message of "Thu, 23 Oct 2008 10:04:41 +0200") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-XM-SPF: eid=;;;mid=;;;hst=mx04.mta.xmission.com;;;ip=24.130.11.59;;;frm=ebiederm@xmission.com;;;spf=neutral X-SA-Exim-Connect-IP: 24.130.11.59 X-SA-Exim-Rcpt-To: too long (recipient list exceeded maximum allowed size of 128 bytes) X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-DCC: XMission; sa04 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Benjamin Thery X-Spam-Relay-Country: X-Spam-Report: * -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -0.2 BAYES_40 BODY: Bayesian spam probability is 20 to 40% * [score: 0.2445] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa04 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 XM_SPF_Neutral SPF-Neutral Subject: Re: [PATCH] netns: Coexist with the sysfs limitations X-SA-Exim-Version: 4.2.1 (built Thu, 07 Dec 2006 04:40:56 +0000) X-SA-Exim-Scanned: Yes (on mx04.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1842 Lines: 52 Benjamin Thery writes: > Serge E. Hallyn wrote: >> Quoting Eric W. Biederman (ebiederm@xmission.com): >>> To make testing of the network namespace simpler allow >>> the network namespace code and the sysfs code to be >>> compiled and run at the same time. To do this only >>> virtual devices are allowed in the additional network >>> namespaces and those virtual devices are not placed >>> in the kobject tree. >>> >>> Since virtual devices don't actually do anything interesting >>> hardware wise that needs device management there should >>> be no loss in keeping them out of the kobject tree and >>> by implication sysfs. The gain in ease of testing >>> and code coverage should be significant. >>> >>> I.e. people running distributions that make it next to >>> impossible to boot without sysfs should at be able to >>> boot a test kernel now. >>> >>> Plus no ABIs are harmed with this patch. > >>> Signed-off-by: Eric W. Biederman >> >> Duh. >> >> Tested-by: Serge Hallyn >> Acked-by: Serge Hallyn > > Oh, this patch is short, clean, and the limitation introduced isn't too > annoying for testing netns right now. > > At least, my proposal provoked some reactions :) Yes. > BTW, there's a second limitation with your patch: > we can't rename the net devices in the additional network namespaces. > > In net/core/dev.c, dev_change_name() fails: call to device_rename() return an > (expected) -EINVAL error. > Maybe we should add a test on the net to only call it in init_net? Yes. Good catch. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/