Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758077AbYJWQjr (ORCPT ); Thu, 23 Oct 2008 12:39:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756421AbYJWQjX (ORCPT ); Thu, 23 Oct 2008 12:39:23 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:32962 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755966AbYJWQjV (ORCPT ); Thu, 23 Oct 2008 12:39:21 -0400 Date: Thu, 23 Oct 2008 18:38:50 +0200 From: Ingo Molnar To: Alexey Dobriyan Cc: Frederic Weisbecker , Geert Uytterhoeven , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH] tracing: fix a build error on alpha and m68k Message-ID: <20081023163850.GB16591@elte.hu> References: <20081023213637.eff9b414.sfr@canb.auug.org.au> <20081023121145.GB27984@x200.localdomain> <49008D12.5090204@gmail.com> <4900B414.7090002@gmail.com> <20081023163433.GA3160@x200.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081023163433.GA3160@x200.localdomain> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00,DNS_FROM_SECURITYSAGE autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.0 DNS_FROM_SECURITYSAGE RBL: Envelope sender in blackholes.securitysage.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1906 Lines: 50 * Alexey Dobriyan wrote: > On Thu, Oct 23, 2008 at 07:27:48PM +0200, Frederic Weisbecker wrote: > > When tracing is enabled, some arch have included > > on their but others like alpha or m68k don't. > > > > Build error on alpha: > > > > kernel/trace/trace.c: In function 'tracing_generic_entry_update': > > kernel/trace/trace.c:658: error: implicit declaration of function 'irqs_disabled_flags' > > kernel/trace/trace.c: In function 'tracing_cpumask_write': > > kernel/trace/trace.c:2145: error: implicit declaration of function 'raw_local_irq_disable' > > kernel/trace/trace.c:2162: error: implicit declaration of function 'raw_local_irq_enable' > > kernel/trace/trace.c: In function 'trace_die_handler': > > kernel/trace/trace.c:3039: error: 'DIE_OOPS' undeclared (first use in this function) > > > > Build error on m68k: > > http://kisskb.ellerman.id.au/kisskb/buildresult/50641/ > > > > > > Include it on kernel/trace/trace.c > > > > Reported-by: Alexey Dobriyan > > Signed-off-by: Frederic Weisbecker > > --- > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > > index 78d5661..deb9684 100644 > > --- a/kernel/trace/trace.c > > +++ b/kernel/trace/trace.c > > @@ -34,6 +34,7 @@ > > > > #include > > #include > > +#include > > Sure, except it doesn't fix anything. hm, zapped the commit then. the problem is most likely that none of these architectures is lockdep enabled, hence they have no irqtrace wrappers, hence not all of the tracers can be built on them? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/