Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758017AbYJWQze (ORCPT ); Thu, 23 Oct 2008 12:55:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754179AbYJWQzZ (ORCPT ); Thu, 23 Oct 2008 12:55:25 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:48076 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753653AbYJWQzY (ORCPT ); Thu, 23 Oct 2008 12:55:24 -0400 Date: Thu, 23 Oct 2008 18:55:04 +0200 From: Ingo Molnar To: =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker Cc: Alexey Dobriyan , Geert Uytterhoeven , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH] tracing: fix a build error on alpha and m68k Message-ID: <20081023165504.GB25697@elte.hu> References: <49008D12.5090204@gmail.com> <4900B414.7090002@gmail.com> <20081023163433.GA3160@x200.localdomain> <20081023163850.GB16591@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00,DNS_FROM_SECURITYSAGE autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.0 DNS_FROM_SECURITYSAGE RBL: Envelope sender in blackholes.securitysage.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1336 Lines: 33 * Fr?d?ric Weisbecker wrote: > But they should be able to use the tracing for several other tracers. > One other problem is that you need CONFIG_TRACE_IRQFLAGS (is that a > lockdep or just trace feature?) to use any tracer since the > tracing_cpumask file is always created for all tracer. This file has > tracing_cpumask_write() as a write operation, and this func uses > raw_local_funcs.... > > Perhaps we should disable the tracing_cpu_mask related things if > TRACE_IRQFLAGS in not configured? to answer the "is that a lockdep or just trace feature" question: trace-irqflags was first written by me for the (crude) ftrace-precursor latency tracer code in -rt, years ago. Then i reused it (and changed it alot) for upstream lockdep, two years ago. Then ftrace came in this year and reused it. so it's rather symbiotic ;-) So ... the tracers that rely on irqflags-tracing should definitely be limited to architectures that provide TRACE_IRQFLAGS. The core trace.c itself should probably not be restricted ... (and it should definitely build) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/