Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757119AbYJWSER (ORCPT ); Thu, 23 Oct 2008 14:04:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755621AbYJWSEA (ORCPT ); Thu, 23 Oct 2008 14:04:00 -0400 Received: from zone0.gcu-squad.org ([212.85.147.21]:15526 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755617AbYJWSD7 (ORCPT ); Thu, 23 Oct 2008 14:03:59 -0400 Date: Thu, 23 Oct 2008 20:03:51 +0200 From: Jean Delvare To: lsorense@csclub.uwaterloo.ca (Lennart Sorensen) Cc: linux-kernel@vger.kernel.org, ben-linux@fluff.org Subject: Re: scx200_i2c driver fails to detect any i2c devices in 2.6.26 (new patch) Message-ID: <20081023200351.29ecfb46@hyperion.delvare> In-Reply-To: <20081023175552.GD5682@csclub.uwaterloo.ca> References: <20081023165419.GA5682@csclub.uwaterloo.ca> <20081023193519.2af62bb5@hyperion.delvare> <20081023175311.GC5682@csclub.uwaterloo.ca> <20081023175552.GD5682@csclub.uwaterloo.ca> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.9; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1059 Lines: 31 On Thu, 23 Oct 2008 13:55:52 -0400, Lennart Sorensen wrote: > The scx200_i2c driver is missing the .class parameter, which means no > i2c drivers are willing to probe for devices on the bus and attach to > them. > > This patch adds the missing .class parameter. > > Signed-off-by: Len Sorensen > > --- scx200_i2c.c 2008-05-20 09:39:24.000000000 -0400 > +++ scx200_i2c.c.new 2008-10-23 13:51:57.000000000 -0400 > @@ -81,6 +81,7 @@ > > static struct i2c_adapter scx200_i2c_ops = { > .owner = THIS_MODULE, > + .class = I2C_CLASS_HWMON | I2C_CLASS_SPD, > .id = I2C_HW_B_SCX200, > .algo_data = &scx200_i2c_data, > .name = "NatSemi SCx200 I2C", > Applied, thanks. I'll also take care to get this patch into 2.6.27-stable and 2.6.26-stable. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/