Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754799AbYJXHdC (ORCPT ); Fri, 24 Oct 2008 03:33:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751090AbYJXHcw (ORCPT ); Fri, 24 Oct 2008 03:32:52 -0400 Received: from mta23.gyao.ne.jp ([125.63.38.249]:31428 "EHLO mx.gate01.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751432AbYJXHcv (ORCPT ); Fri, 24 Oct 2008 03:32:51 -0400 Date: Fri, 24 Oct 2008 16:32:12 +0900 From: Paul Mundt To: Jens Axboe Cc: Alexander Beregalov , tj@kernel.org, torvalds@linux-foundation.org, LKML , linux-ide@vger.kernel.org Subject: Re: 2.6.27-rc1 (2fca5c): libata: kernel cant boot Message-ID: <20081024073212.GA4008@linux-sh.org> Mail-Followup-To: Paul Mundt , Jens Axboe , Alexander Beregalov , tj@kernel.org, torvalds@linux-foundation.org, LKML , linux-ide@vger.kernel.org References: <20081024070955.GN22217@kernel.dk> <20081024071329.GO22217@kernel.dk> <20081024071608.GA3879@linux-sh.org> <20081024072428.GP22217@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081024072428.GP22217@kernel.dk> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 36 On Fri, Oct 24, 2008 at 09:24:29AM +0200, Jens Axboe wrote: > On Fri, Oct 24 2008, Paul Mundt wrote: > > On Fri, Oct 24, 2008 at 09:13:29AM +0200, Jens Axboe wrote: > > > Darn, this smells like a train wreck. I'm assuming this fixes it? > > > > > Yes, that fixes it. > > OK, that's pretty bad. 2.6.28-rc1 will not work on any box using libata > with non-ncq disks. If you need me, I'll be at the bar. > At least you only missed -rc1 by a few hours, it was a good effort.. :-) > From e598055dde1951c47c8b3522616f6ebff0ed9847 Mon Sep 17 00:00:00 2001 > From: Jens Axboe > Date: Fri, 24 Oct 2008 09:22:42 +0200 > Subject: [PATCH] libata: fix bug with non-ncq devices > > The recent commit 201f1b98822078c808b5e2d379a6ddbfc0a06ee1 to enable > support for block layer tagging in libata was broken for non-NCQ > devices. The block layer initializes the tag field to -1 to detect > invalid uses of a tag, and if the libata devices does NOT support > NCQ, we just used that field to index the internal command list. > So we need to check for -1 first and only use the tag field if > it's valid. > > Signed-off-by: Jens Axboe Tested-by: Paul Mundt Thanks for the quick fix! Now I can go back to hacking on the stuff I was avoiding.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/