From: Rusty Russell <rusty@rustcorp.com.au>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Subject: Re: [PATCH -tip/cpus4096-v2] cpumask: fix memory leak and cpumask corruption
Date: Fri, 24 Oct 2008 19:55:29 +1100
User-Agent: KMail/1.9.10
Cc: Ingo Molnar <mingo@elte.hu>, Mike Travis <travis@sgi.com>,
       linux-kernel@vger.kernel.org
References: <4901564F.7020308@ct.jp.nec.com>
In-Reply-To: <4901564F.7020308@ct.jp.nec.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200810241955.29400.rusty@rustcorp.com.au>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 965
Lines: 28

On Friday 24 October 2008 15:59:59 Hiroshi Shimamoto wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>

Hi Hiroshi,

   Thanks for looking at this!

> On CONFIG_CPUMASK_OFFSTACK enabled kernel, when exiting
> smp_call_function_many() without calling arch_send_call_function_ipi()
> allbutself should be freed.

   That bit's OK, changing the return to "goto out;".

> Also, the memory for allbutself shouldn't be freed when
> arch_send_call_function_ipi() is called.  The memory region will be
> referenced in generic_smp_call_function_interrupt(). And the memory
> will be freed at rcu_free_call_data().

As your next patch shows, this should be solved a different way.  I'll comment 
there.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/