Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757411AbYJXVPn (ORCPT ); Fri, 24 Oct 2008 17:15:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753030AbYJXVPg (ORCPT ); Fri, 24 Oct 2008 17:15:36 -0400 Received: from waste.org ([66.93.16.53]:43853 "EHLO waste.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751198AbYJXVPg (ORCPT ); Fri, 24 Oct 2008 17:15:36 -0400 Subject: Re: Bloatwatch 2.6.28-rc1: last_sysfs_file From: Matt Mackall To: Linux Kernel Mailing List Cc: akpm In-Reply-To: <1224881514.3248.46.camel@calx> References: <1224881514.3248.46.camel@calx> Content-Type: text/plain Date: Fri, 24 Oct 2008 16:15:23 -0500 Message-Id: <1224882923.3248.51.camel@calx> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1295 Lines: 38 On Fri, 2008-10-24 at 15:52 -0500, Matt Mackall wrote: > 2.6.28-rc1 adds 4k for last_sysfs_file debug tracking. That's one hell > of a long sysfs path. > > http://www.selenic.com/bloatwatch/?cmd=compare;v1=2.6.27;v2=2.6.28-rc1;part=/built-in/fs/sysfs ..especially given that printk is limited to 1k at a time. sysfs: shrink last_sysfs_file to a reasonable size sysfs was reserving 4k to store filenames for debug despite printk being limited to 1k. Shrink this to something more reasonable. Signed-off-by: Matt Mackall diff -r ac8c82ff3be7 fs/sysfs/file.c --- a/fs/sysfs/file.c Fri Oct 24 13:13:04 2008 -0500 +++ b/fs/sysfs/file.c Fri Oct 24 16:11:53 2008 -0500 @@ -25,7 +25,7 @@ #include "sysfs.h" /* used in crash dumps to help with debugging */ -static char last_sysfs_file[PATH_MAX]; +static char last_sysfs_file[200]; /* allow for disgustingly long paths */ void sysfs_printk_last_file(void) { printk(KERN_EMERG "last sysfs file: %s\n", last_sysfs_file); -- Mathematics is the supreme nostalgia of our time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/