Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756786AbYJXVeI (ORCPT ); Fri, 24 Oct 2008 17:34:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754708AbYJXVdy (ORCPT ); Fri, 24 Oct 2008 17:33:54 -0400 Received: from ns2.suse.de ([195.135.220.15]:42636 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbYJXVdx (ORCPT ); Fri, 24 Oct 2008 17:33:53 -0400 Date: Fri, 24 Oct 2008 14:28:04 -0700 From: Greg KH To: Elias Oltmanns Cc: linux-kernel@vger.kernel.org, stable@kernel.org, jejb@kernel.org, Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , Willy Tarreau , Rodrigo Rubira Branco , Jake Edge , Eugene Teo , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Bob Copeland , "John W. Linville" Subject: Re: [patch 27/27] ath5k: fix suspend-related oops on rmmod Message-ID: <20081024212804.GA15776@suse.de> References: <20081024042023.054190751@mini.kroah.org> <20081024043530.GB30828@kroah.com> <87ej253f3r.fsf@denkblock.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87ej253f3r.fsf@denkblock.local> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1749 Lines: 39 On Fri, Oct 24, 2008 at 10:36:24PM +0200, Elias Oltmanns wrote: > Greg KH wrote: > > 2.6.27-stable review patch. If anyone has any objections, please let us > > know. > > > > ------------------ > > From: Bob Copeland > > > > commit 8bdd5b9c6bd53add260756b6673a0545fbdbba21 upstream > > > > Based on a patch by Elias Oltmanns, we call ath5k_init in resume even > > if we didn't previously open the device. Besides starting up the > > device unnecessarily, this also causes an oops on rmmod because > > mac80211 will not invoke ath5k_stop and softirqs are left running after > > the module has been unloaded. Add a new state bit, ATH_STAT_STARTED, > > to indicate that we have been started up. > > > > Reported-by: Toralf F?rster > > Signed-off-by: Elias Oltmanns > > Signed-off-by: Bob Copeland > > Signed-off-by: John W. Linville > > Signed-off-by: Greg Kroah-Hartman > > I've done some more testing and I'm ashamed to say that this patch is > incomplete and does indeed introduce a regression itself. Having only > just sent the fix to John, I'm afraid this patch has to be deferred for > the next stable release since the required fix is not likely to hit > Linus' tree in time. Anyway, I'm adding my patch and the changelog entry > by way of explanation. Ok, I've dropped this from the 2.6.27-stable queue now, thanks for letting me know. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/