Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752747AbYJYK7g (ORCPT ); Sat, 25 Oct 2008 06:59:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751450AbYJYK73 (ORCPT ); Sat, 25 Oct 2008 06:59:29 -0400 Received: from smtp.nokia.com ([192.100.105.134]:54311 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbYJYK72 convert rfc822-to-8bit (ORCPT ); Sat, 25 Oct 2008 06:59:28 -0400 Subject: Re: [PATCH] ubifs: endian handling fixes and annotations From: Artem Bityutskiy Reply-To: dedekind@infradead.org To: Harvey Harrison Cc: Adrian Hunter , Andrew Morton , LKML In-Reply-To: <1224870777.5966.3.camel@brick> References: <1224870777.5966.3.camel@brick> Content-Type: text/plain; charset=utf-8 Date: Sat, 25 Oct 2008 13:57:36 +0300 Message-Id: <1224932256.4466.135.camel@sauron> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 8BIT X-OriginalArrivalTime: 25 Oct 2008 10:58:48.0022 (UTC) FILETIME=[A819BF60:01C93690] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1899 Lines: 40 Harvey, On Fri, 2008-10-24 at 10:52 -0700, Harvey Harrison wrote: > Noticed by sparse: > fs/ubifs/file.c:75:2: warning: restricted __le64 degrades to integer > fs/ubifs/file.c:629:4: warning: restricted __le64 degrades to integer > fs/ubifs/dir.c:431:3: warning: restricted __le64 degrades to integer > > This should be checked to ensure the ubifs_assert is working as > intended, I've done the suggested annotation in this patch. > > fs/ubifs/sb.c:298:6: warning: incorrect type in assignment (different base types) > fs/ubifs/sb.c:298:6: expected int [signed] [assigned] tmp > fs/ubifs/sb.c:298:6: got restricted __le64 [usertype] > fs/ubifs/sb.c:299:19: warning: incorrect type in assignment (different base types) > fs/ubifs/sb.c:299:19: expected restricted __le64 [usertype] atime_sec > fs/ubifs/sb.c:299:19: got int [signed] [assigned] tmp > fs/ubifs/sb.c:300:19: warning: incorrect type in assignment (different base types) > fs/ubifs/sb.c:300:19: expected restricted __le64 [usertype] ctime_sec > fs/ubifs/sb.c:300:19: got int [signed] [assigned] tmp > fs/ubifs/sb.c:301:19: warning: incorrect type in assignment (different base types) > fs/ubifs/sb.c:301:19: expected restricted __le64 [usertype] mtime_sec > fs/ubifs/sb.c:301:19: got int [signed] [assigned] tmp ... snip ... thanks for the patch. It's shame we did not fix this ourselves. We did run sparse before submitting UBIFS and did not see these warnings. Probably sparse has been improved recently. Anyway, thank you, I'll look closer at your patch and apply it to ubifs-2.6.git. -- Best regards, Artem Bityutskiy (Битюцкий Артём) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/