Message-ID: <49033E1B.9030406@skyrush.com>
Date: Sat, 25 Oct 2008 09:41:15 -0600
From: Joe Peterson <joe@skyrush.com>
User-Agent: Thunderbird 2.0.0.17 (X11/20081002)
MIME-Version: 1.0
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
CC: Linux Kernel <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] n-tty-output-bells-immediately
References: <48F2E450.1070508@skyrush.com>	<20081022103259.2d04729a@lxorguk.ukuu.org.uk>	<48FFD4F9.6090105@skyrush.com> <20081024101029.6e826234@lxorguk.ukuu.org.uk>
In-Reply-To: <20081024101029.6e826234@lxorguk.ukuu.org.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1237
Lines: 29

Alan Cox wrote:
> Ok without randomly hitting send this time...
> 
> LC/UC and control characters looks right.  (except the added white space)
> Buffer sizing looks fine
> Bell definitely a good idea
> 
> Those three applied with better subject lines and queued for .29
> 
> The last one I'm rather less happy with but want to ponder a bit more the
> best way to handle.

All sounds good - thanks.  Yes, let's think a bit more about the last
one.  The problem, as I see it now, is that only the ldisc knows how to
treat certain chars, but the input buffers get clogged before they get
to the ldisc.  Perhaps devising a way for upstream input code to call
the ldisc to inform it that there is a "signal pending/queued" (i.e.
SIGINT, SIGQUIT, SIGSTP) or a tty restart (e.g. ^Q) queued...

BTW, where are the patches sitting at this point?  I saw an email about
"linux-next" that lists just the first of the 3 (the drop bkl one); and
your tty git is now empty.  Just curious.

					Thanks!  Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/