Subject: Re: [PATCH] ubifs: endian handling fixes and annotations
From: Artem Bityutskiy <dedekind@infradead.org>
Reply-To: dedekind@infradead.org
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Adrian Hunter <ext-adrian.hunter@nokia.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <1224960775.5784.13.camel@brick>
References: <1224870777.5966.3.camel@brick>
	 <1224932256.4466.135.camel@sauron>  <1224960775.5784.13.camel@brick>
Content-Type: text/plain; charset=utf-8
Date: Sun, 26 Oct 2008 15:22:33 +0200
Message-Id: <1225027353.4466.144.camel@sauron>
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1241
Lines: 29

On Sat, 2008-10-25 at 11:52 -0700, Harvey Harrison wrote:
> > > fs/ubifs/sb.c:300:19: warning: incorrect type in assignment (different base types)
> > > fs/ubifs/sb.c:300:19:    expected restricted __le64 [usertype] ctime_sec
> > > fs/ubifs/sb.c:300:19:    got int [signed] [assigned] tmp
> > > fs/ubifs/sb.c:301:19: warning: incorrect type in assignment (different base types)
> > > fs/ubifs/sb.c:301:19:    expected restricted __le64 [usertype] mtime_sec
> > > fs/ubifs/sb.c:301:19:    got int [signed] [assigned] tmp
> > 
> > ... snip ...
> > 
> > thanks for the patch. It's shame we did not fix this ourselves. We did
> > run sparse before submitting UBIFS and did not see these warnings.
> > Probably sparse has been improved recently. Anyway, thank you, I'll look
> > closer at your patch and apply it to ubifs-2.6.git.
> > 
> 
> Run sparse with -D__CHECK_ENDIAN__ to see these warnings.

Any idea why this is not default?

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/