Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755229AbYJZOLo (ORCPT ); Sun, 26 Oct 2008 10:11:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753948AbYJZOLg (ORCPT ); Sun, 26 Oct 2008 10:11:36 -0400 Received: from qw-out-2122.google.com ([74.125.92.25]:64356 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752295AbYJZOLf (ORCPT ); Sun, 26 Oct 2008 10:11:35 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=WEqJAqlkSKO5PrHhtiDj/9NfjyuDJ4Ru1ckCciHc94XJXK5ram229XPCGWWFvpKL6f JBqP921ldOg4hdF5Ma/3f7eyjtkiIM4TB9Zh6t4t2413fi2UOhr9Ipc2VO09bkSpR7XV rkIZlCTfItoLY9M3EpUyeh0AZ3j7hZT/0ZXjY= Message-ID: Date: Sun, 26 Oct 2008 15:11:33 +0100 From: "Leon Woestenberg" To: "Peter Zijlstra" Subject: Re: [PATCH] Rename DECLARE_MUTEX to DEFINE_SEMAPHORE Cc: "Marcin Slusarz" , "Andrew Morton" , "Linus Torvalds" , "Matthew Wilcox" , LKML In-Reply-To: <1225028346.32713.11.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20081026120609.GA10728@joi> <1225028346.32713.11.camel@twins> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 833 Lines: 26 Hello, On Sun, Oct 26, 2008 at 2:39 PM, Peter Zijlstra wrote: > On Sun, 2008-10-26 at 13:06 +0100, Marcin Slusarz wrote: >> DECLARE_MUTEX is doubly misleading name (it actually _defines_ struct >> _semaphore_ initialized to 1) and it can be confused with DEFINE_MUTEX >> (which defines real struct mutex). Rename it. > > I'd prefer DEFINE_BINARY_SEM or somesuch > But it is not a binary semaphore, or is it? Also, at least under 2.6.24, #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) thus the DECLARE is wrong there as well? Regards, -- Leon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/