Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755231AbYJZOlS (ORCPT ); Sun, 26 Oct 2008 10:41:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754449AbYJZOlG (ORCPT ); Sun, 26 Oct 2008 10:41:06 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:57858 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752471AbYJZOlE (ORCPT ); Sun, 26 Oct 2008 10:41:04 -0400 Subject: Re: [PATCH] Rename DECLARE_MUTEX to DEFINE_SEMAPHORE From: Peter Zijlstra To: Leon Woestenberg Cc: Marcin Slusarz , Andrew Morton , Linus Torvalds , Matthew Wilcox , LKML In-Reply-To: References: <20081026120609.GA10728@joi> <1225028346.32713.11.camel@twins> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Sun, 26 Oct 2008 15:41:03 +0100 Message-Id: <1225032063.32713.17.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 865 Lines: 21 On Sun, 2008-10-26 at 15:11 +0100, Leon Woestenberg wrote: > Hello, > > On Sun, Oct 26, 2008 at 2:39 PM, Peter Zijlstra wrote: > > On Sun, 2008-10-26 at 13:06 +0100, Marcin Slusarz wrote: > >> DECLARE_MUTEX is doubly misleading name (it actually _defines_ struct > >> _semaphore_ initialized to 1) and it can be confused with DEFINE_MUTEX > >> (which defines real struct mutex). Rename it. > > > > I'd prefer DEFINE_BINARY_SEM or somesuch > > > But it is not a binary semaphore, or is it? > #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) I thought that 1 made it a binary sem. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/