Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755114AbYJZQ1d (ORCPT ); Sun, 26 Oct 2008 12:27:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751222AbYJZQ1V (ORCPT ); Sun, 26 Oct 2008 12:27:21 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:57326 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751162AbYJZQ1V (ORCPT ); Sun, 26 Oct 2008 12:27:21 -0400 Message-ID: <49049A33.2080203@pobox.com> Date: Sun, 26 Oct 2008 12:26:27 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Francois Romieu CC: Linus Torvalds , David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alistair John Strachan , Ivan Vecera , Chuck Ebbert , Krzysztof Halasa , Petr Vandrovec , Plamen Petrov , =?ISO-8859-1?Q?Ilpo_J=E4rvinen?= , =?ISO-8859-1?Q?=22J=2EA=2E_Magall=F3n=22?= , Jiri Slaby , Simon Arlott , Andrew Morton , Edward Hsu Subject: Re: [PATCH 1/1] r8169: revert "read MAC address from EEPROM on init" References: <20081026160249.GA25443@electric-eye.fr.zoreil.com> In-Reply-To: <20081026160249.GA25443@electric-eye.fr.zoreil.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 998 Lines: 26 Francois Romieu wrote: > This reverts commit 7bf6bf4803df1adc927f585168d2135fb019c698. > > The code has both a short existence and an increasing track > of failures despite some work to amend it for -rc1. It is not > just a matter of reading the eeprom: sometimes the eeprom is > read correctly, then the mac address is not written correctly > back into the mac registers. > > Some chipsets seem to work reliably but it is not clear at > this point if the code can simply be made to work on a > per-chipset basis and post -rc1 is not the place where I want > to experiment these things. > > Signed-off-by: Francois Romieu Acked-by: Jeff Garzik I'll send upstream if Linus doesn't pick it up shortly... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/