Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752856AbYJ0Knw (ORCPT ); Mon, 27 Oct 2008 06:43:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751406AbYJ0Knn (ORCPT ); Mon, 27 Oct 2008 06:43:43 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:51095 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328AbYJ0Knm (ORCPT ); Mon, 27 Oct 2008 06:43:42 -0400 Date: Mon, 27 Oct 2008 11:43:25 +0100 From: Ingo Molnar To: Hidehiro Kawai Cc: Theodore Tso , Linus Torvalds , Vegard Nossum , Jan Kara , Stephen Rothwell , Al Viro , linux-ext4@vger.kernel.org, Andrew Morton , "Rafael J. Wysocki" , Pekka Enberg , linux-kernel@vger.kernel.org, sugita , Satoshi OSHIMA Subject: Re: [PATCH 2/2] ext4: fix a bug accessing freed memory in ext4_abort Message-ID: <20081027104325.GA13641@elte.hu> References: <19f34abd0810250422t17990222x78fcf0fad2e6f04b@mail.gmail.com> <49056D29.2010700@hitachi.com> <49056FA5.7070202@hitachi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49056FA5.7070202@hitachi.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00,DNS_FROM_SECURITYSAGE autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.0 DNS_FROM_SECURITYSAGE RBL: Envelope sender in blackholes.securitysage.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 840 Lines: 21 * Hidehiro Kawai wrote: > Vegard Nossum reported a bug which accesses freed memory. When > journal has been aborted, ext4_put_super() calls ext4_abort() after > freeing the journal_t object, and then ext4_abort() accesses it. > This patch fix it. > > Signed-off-by: Hidehiro Kawai could you please put the word "kmemcheck" into the commit log? ("found via kmemcheck" or so) We want to have an easily git-greppable track record of upstream kernel bugs that were found via kmemcheck. (and there's already a long list) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/