Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752469AbYJ0Olc (ORCPT ); Mon, 27 Oct 2008 10:41:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750779AbYJ0OlY (ORCPT ); Mon, 27 Oct 2008 10:41:24 -0400 Received: from smtp-vbr5.xs4all.nl ([194.109.24.25]:3948 "EHLO smtp-vbr5.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750727AbYJ0OlY (ORCPT ); Mon, 27 Oct 2008 10:41:24 -0400 Date: Mon, 27 Oct 2008 15:40:32 +0100 (CET) From: Roman Zippel X-X-Sender: roman@localhost.localdomain To: Al Viro cc: Linus Torvalds , Sam Ravnborg , linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix allmodconfig breakage In-Reply-To: <20081026051234.GN28946@ZenIV.linux.org.uk> Message-ID: References: <20081025211107.GA20417@uranus.ravnborg.org> <20081026051234.GN28946@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1188 Lines: 33 Hi, On Sun, 26 Oct 2008, Al Viro wrote: > If you use KCONFIG_ALLCONFIG (even with empty file) you get > broken allmodconfig/allyesconfig; CONFIG_MODULES gets turned off, > with obvious massive fallout. > > Breakage had been introduced when conf_set_all_new_symbols() > got used for allmodconfig et.al. > > What happens is that sym_calc_value(modules_sym) done in > conf_read_simple() sets SYMBOL_VALID on both modules_sym and MODULES. > When we get to conf_set_all_new_symbols(), we set sym->def[S_DEF_USER] > on everything, but it has no effect on sym->curr for the symbols that > already have SYMBOL_VALID - these are stuck. > > Solution: use sym_clear_all_valid() in there. Note that it > makes reevaluation of modules_sym redundant - sym_clear_all_valid() > will do that itself. > > Signed-off-by: Al Viro Thanks for looking into this. Signed-off-by: Roman Zippel bye, Roman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/