Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752838AbYJ0Pik (ORCPT ); Mon, 27 Oct 2008 11:38:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751568AbYJ0Pi2 (ORCPT ); Mon, 27 Oct 2008 11:38:28 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:47842 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752463AbYJ0Pi1 (ORCPT ); Mon, 27 Oct 2008 11:38:27 -0400 From: Mark Brown To: Alessandro Zummo , David Brownell Cc: Andrew Morton , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, Mark Brown Subject: [PATCH 1/2] rtc: Fix handling of missing tm_year data when reading alarms Date: Mon, 27 Oct 2008 15:38:24 +0000 Message-Id: <1225121905-23782-1-git-send-email-broonie@opensource.wolfsonmicro.com> X-Mailer: git-send-email 1.5.6.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 30 When fixing up invalid years rtc_read_alarm() is callign rtc_valid_tm() as a boolean but rtc_valid_tm() returns zero on success or a negative number if the time is not valid so the test is inverted. Signed-off-by: Mark Brown --- drivers/rtc/interface.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c index 7af60b9..a04c1b6 100644 --- a/drivers/rtc/interface.c +++ b/drivers/rtc/interface.c @@ -271,7 +271,7 @@ int rtc_read_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) dev_dbg(&rtc->dev, "alarm rollover: %s\n", "year"); do { alarm->time.tm_year++; - } while (!rtc_valid_tm(&alarm->time)); + } while (rtc_valid_tm(&alarm->time) != 0); break; default: -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/