Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753418AbYJ0QwV (ORCPT ); Mon, 27 Oct 2008 12:52:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752029AbYJ0QwM (ORCPT ); Mon, 27 Oct 2008 12:52:12 -0400 Received: from mx0.towertech.it ([213.215.222.73]:57599 "HELO mx0.towertech.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751092AbYJ0QwL (ORCPT ); Mon, 27 Oct 2008 12:52:11 -0400 Date: Mon, 27 Oct 2008 17:51:59 +0100 From: Alessandro Zummo To: rtc-linux@googlegroups.com Cc: broonie@opensource.wolfsonmicro.com, David Brownell , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] rtc: Fix handling of missing tm_year data when reading alarms Message-ID: <20081027175159.14d51466@i1501.lan.towertech.it> In-Reply-To: <1225121905-23782-1-git-send-email-broonie@opensource.wolfsonmicro.com> References: <1225121905-23782-1-git-send-email-broonie@opensource.wolfsonmicro.com> Organization: Tower Technologies X-Mailer: Sylpheed X-This-Is-A-Real-Message: Yes Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 769 Lines: 25 On Mon, 27 Oct 2008 15:38:24 +0000 Mark Brown wrote: > When fixing up invalid years rtc_read_alarm() is callign rtc_valid_tm() > as a boolean but rtc_valid_tm() returns zero on success or a negative > number if the time is not valid so the test is inverted. > > Signed-off-by: Mark Brown Acked-by: Alessandro Zummo -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/