Date: Mon, 27 Oct 2008 19:26:55 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Mathieu Desnoyers <compudj@krystal.dyndns.org>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH tip/tracing/markers] new probes manager
Message-ID: <20081027182655.GA11494@elte.hu>
References: <48FFE5CB.2050608@cn.fujitsu.com> <20081027155832.GB17250@Krystal> <20081027163046.GA20692@Krystal>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081027163046.GA20692@Krystal>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 939
Lines: 28


* Mathieu Desnoyers <compudj@krystal.dyndns.org> wrote:

> * Mathieu Desnoyers (mathieu.desnoyers@polymtl.ca) wrote:
> > * Lai Jiangshan (laijs@cn.fujitsu.com) wrote:
> > > 
> > > this patch use a new probes manager for marker.
> > > 
> > > the most important benefit of this patch is:
> > > 	1) smp_rmb() is removed from the critical path. as we know rmb()
> > > 	   is very expensive.
> > > 
> > 
> > Do you have performance measurements for this ? On x86 it's a nop,
> > AFAIK.
> 
> My statement above is inexact : x86_64 uses lfence for rmb(). But
> numbers would still be welcome.

yes, the statement that rmb() is very expensive looks dubious. It is 
absolutely cheap everywhere.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/