From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
To: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] fix comile error of hdpuftrs
Date: Mon, 27 Oct 2008 22:46:58 +0100
User-Agent: KMail/1.9.9
Cc: lkml <linux-kernel@vger.kernel.org>
References: <200810181537.13653.m.kozlowski@tuxland.pl> <20081026212401.f3a6ee4d.akpm@linux-foundation.org>
In-Reply-To: <20081026212401.f3a6ee4d.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200810272246.59328.m.kozlowski@tuxland.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1172
Lines: 32

Hi,

> > drivers/misc/hdpuftrs/hdpu_nexus.c:118: error: expected identifier or '(' before 'return'
> > drivers/misc/hdpuftrs/hdpu_nexus.c:119: error: expected identifier or '(' before '}' token
> > 
> > Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
> > 
> > --- a/drivers/misc/hdpuftrs/hdpu_nexus.c
> > +++ b/drivers/misc/hdpuftrs/hdpu_nexus.c
> > @@ -113,7 +113,6 @@ static int hdpu_nexus_probe(struct platform_device *pdev)
> >  	if (!hdpu_chassis_id)
> >  		printk(KERN_WARNING "sky_nexus: "
> >  		       "Unable to create proc dir entry: sky_chassis_id\n");
> > -	}
> > 
> >  	return 0;
> >  }
> 
> This has been broken since 2.6.26.
> 
> Nobody noticed because there is no way of enabling CONFIG_HDPU_FEATURES
> in Kconfig.  I wonder what's up with that.

Yup. I used simple script to find the brace imbalance. Then I tried to compile it with
make drivers/misc/hdpuftrs/hdpu_nexus.o to verify this.

	Mariusz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/