Date: Mon, 27 Oct 2008 22:52:33 +0100
From: Bernhard Walle <bwalle@suse.de>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
       Thomas Mingarelli <thomas.mingarelli@hp.com>,
       Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH] [WATCHDOG] Fix kdump when using hpwdt
Message-ID: <20081027225233.34758cda@kopernikus.site>
In-Reply-To: <20081027193053.GA2659@infomag.infomag.iguana.be>
References: <1225033177-5311-1-git-send-email-bwalle@suse.de>
	<20081027193053.GA2659@infomag.infomag.iguana.be>
Organization: SUSE Linux Products GmbH
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 981
Lines: 30

Hi Wim,

* Wim Van Sebroeck [2008-10-27 20:30]:

> > -module_param(allow_kdump, int, 0);
> > +module_param(allow_kdump, int, 1);
> >  MODULE_PARM_DESC(allow_kdump, "Start a kernel dump after NMI occurs");
> 
> the syntax is: #define module_param(name, type, perm)
> perm sets the visibility in sysfs: 000 means it's not there,
> read bits mean it's readable, write bits mean it's writable.
> 
> perm is not the default value for the integer but a file permission attribute.

Yeah, thanks for spotting that. I was a bit in hurry while creating the
patch ...

I'll come up with an updated patch with the suggestions from Vivek.
Probably tomorrow.


Regards,
Bernhard
-- 
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/