Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753169AbYJ1GQh (ORCPT ); Tue, 28 Oct 2008 02:16:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752478AbYJ1GQ2 (ORCPT ); Tue, 28 Oct 2008 02:16:28 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:42863 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752436AbYJ1GQ1 (ORCPT ); Tue, 28 Oct 2008 02:16:27 -0400 Date: Mon, 27 Oct 2008 23:15:33 -0700 From: Andrew Morton To: Takashi Sato Cc: Christoph Hellwig , "linux-fsdevel@vger.kernel.org" , "dm-devel@redhat.com" , "viro@ZenIV.linux.org.uk" , "linux-ext4@vger.kernel.org" , "xfs@oss.sgi.com" , "mtk.manpages@googlemail.com" , "axboe@kernel.dk" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/3] Implement generic freeze feature Message-Id: <20081027231533.96c42a78.akpm@linux-foundation.org> In-Reply-To: <20081027215855t-sato@mail.jp.nec.com> References: <20081027215855t-sato@mail.jp.nec.com> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 748 Lines: 22 On Mon, 27 Oct 2008 21:58:54 +0900 Takashi Sato wrote: > -void thaw_bdev(struct block_device *bdev, struct super_block *sb) > +int thaw_bdev(struct block_device *bdev, struct super_block *sb) > { > + int error = 0; > + > + mutex_lock(&bdev->bd_fsfreeze_mutex); > + if (!bdev->bd_fsfreeze_count) { > + mutex_unlock(&bdev->bd_fsfreeze_mutex); > + return -EINVAL; This would be a programming error, yes? If so, a WARN_ON is more appropriate than a silent runtime error. > + } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/