Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753517AbYJ1KrS (ORCPT ); Tue, 28 Oct 2008 06:47:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752705AbYJ1KrJ (ORCPT ); Tue, 28 Oct 2008 06:47:09 -0400 Received: from mail.suse.de ([195.135.220.2]:50110 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752692AbYJ1KrI (ORCPT ); Tue, 28 Oct 2008 06:47:08 -0400 Date: Tue, 28 Oct 2008 11:47:05 +0100 Message-ID: From: Takashi Iwai To: Ingo Molnar Cc: FUJITA Tomonori , svens@stackframe.org, joerg.roedel@amd.com, linux-kernel@vger.kernel.org, "H. Peter Anvin" Subject: Re: swiotlb_alloc_coherent: allocated memory is out of range for device In-Reply-To: <20081028103902.GB22319@elte.hu> References: <20081022221321J.fujita.tomonori@lab.ntt.co.jp> <20081023113618T.fujita.tomonori@lab.ntt.co.jp> <20081023101557.GA30302@elte.hu> <20081028103902.GB22319@elte.hu> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1624 Lines: 49 At Tue, 28 Oct 2008 11:39:02 +0100, Ingo Molnar wrote: > > > * Takashi Iwai wrote: > > > At Thu, 23 Oct 2008 12:15:57 +0200, > > Ingo Molnar wrote: > > > > > > > > > * Takashi Iwai wrote: > > > > > > > At Thu, 23 Oct 2008 07:22:09 +0200, > > > > I wrote: > > > > > > > > > > > The current dma_alloc_coherent (asm-x86/dma-mapping.h) handles the gfp > > > > > > flags in the exact same way as the old dma_alloc_coherent > > > > > > (pci-dma.c). Neither sets GFP_DMA even if coherent_dma_mask is > > > > > > 24bits. The old code is fine because of the GFP_DMA retry > > > > > > mechanism. But if coherent_dma_mask is 24bits, there is no point to go > > > > > > into the GFP_DMA retry mechanism. We should use GFP_DMA in the first > > > > > > place. > > > > > > > > > > > > How about the following patch? > > > > > > > > > > I'll give it a try later (the machine is in my office). > > > > > > > > The patch seems working fine. Thanks! > > > > > > > > Tested-by: Takashi Iwai > > > > > > thanks guys - i've queued it up in tip/core/urgent and will send a pull > > > request to Linus later today. > > > > Ingo, what is the status about these patches? > > They don't appear in rc2. > > Will send it today-ish. -rc2 was strictly for brown paperbag bugs > crashing more than half of all testsystems. OK, thanks! Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/