Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753873AbYJ1Slc (ORCPT ); Tue, 28 Oct 2008 14:41:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752738AbYJ1SlH (ORCPT ); Tue, 28 Oct 2008 14:41:07 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:34148 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751918AbYJ1SlF (ORCPT ); Tue, 28 Oct 2008 14:41:05 -0400 Date: Tue, 28 Oct 2008 14:41:04 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Theodore Tso cc: LKML , Mike Snitzer , Andrew Morton , Ingo Molnar , Thomas Gleixner , Peter Zijlstra , Arjan van de Ven , Frederic Weisbecker Subject: Re: [PATCH][RFC] trace: profile likely and unlikely annotations In-Reply-To: <20081028182952.GB10862@mit.edu> Message-ID: References: <170fa0d20810271529g3c64ae89me29ed8b65a9c3b5e@mail.gmail.com> <20081028001340.GB9797@mit.edu> <20081028143720.GD8869@mit.edu> <20081028182952.GB10862@mit.edu> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1375 Lines: 39 On Tue, 28 Oct 2008, Theodore Tso wrote: > On Tue, Oct 28, 2008 at 10:49:16AM -0400, Steven Rostedt wrote: > > > > OK, I'm fine with changing the terminology. v2 will do: > > > > s/hit/True/ > > s/missed/False/ > > > > Fine with you? > > I'm OK with either that, or with Arjan's suggestion of "Correct" and > "Incorrect" --- although that would changing a line in the definition > of #define unlikely(x): > > ftrace_likely_update(&______f, !______r); > > Either "True" / "False" or "Correct" / "Incorrect" has the advantage > of being unambiguous. "Correct" / "Incorrect" has the advantage that > people don't have to think about the fact that for > /proc/profile_unlikely, high numbers of "False" is a good thing, where > as for /proc/profile_likely, high numbers of "True" is a good thing. > With "Correct" / "Incorrect" it's easier to undersatnd that high > numbers of "Correct" is good. > > So I can see why Arjan suggested Correct/Incorrect, although I can > live with either. I'm almost done with v2. Using Arjan's version (Correct/Incorrect) was actually a trivial change. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/