Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754463AbYJ1UVB (ORCPT ); Tue, 28 Oct 2008 16:21:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753837AbYJ1UUo (ORCPT ); Tue, 28 Oct 2008 16:20:44 -0400 Received: from smtp115.sbc.mail.sp1.yahoo.com ([69.147.64.88]:44172 "HELO smtp115.sbc.mail.sp1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753685AbYJ1UUm (ORCPT ); Tue, 28 Oct 2008 16:20:42 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=pacbell.net; h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id; b=Ng2kd+ZPXJkJRLUZ0PXwgqq0RHcQtKrwuKccSCConaOOAYKwcRStnc3vnEWkl2rDBbOI24QO0DBO0XwwHs9MTIRFx8+AezyPYYtDMn3HpxT8nnYEBgNZ1fLBn/lk0ykXLGuJYI/+EreU2K0HE4FAo/vJGAHN/65uN/wC8kDlTSA= ; X-YMail-OSG: EymZkbMVM1l8CIe7zgIM91X86DGmi8_oSHshen1ERncTISWgnSJJ7zqvbHfLLyqzbkDYXHKLTU7.WGMI6wIl5NzTnYF4BZ1UfY2PleiF7ZDErJ2m1FNVZL3s02ebVW4jVeI- X-Yahoo-Newman-Property: ymail-3 From: David Brownell To: "Andrew Victor" Subject: Re: [patch 2.6.28-rc2] atmel_serial: keep clock off when it's not needed Date: Tue, 28 Oct 2008 12:51:29 -0700 User-Agent: KMail/1.9.10 Cc: "Haavard Skinnemoen" , lkml , "Haavard Skinnemoen" , "Nicolas Ferre" References: <200810271406.24110.david-b@pacbell.net> <200810280920.19864.david-b@pacbell.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810281251.30031.david-b@pacbell.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1102 Lines: 38 On Tuesday 28 October 2008, Andrew Victor wrote: > hi David, > > > I verified it on AT91, where the console is normally DBGU and the > > other USARTs do get an open(). > > The DBGU is part of the system peripherals, which are clocked from MCK > and which is always enabled. Exactly. > Therefore I don't think this is a valid test-case. Not for the oddball case Haavard mentioned, no: the console port being something the boot loader wasn't using, which couldn't show the early boot messages (before console setup) in any case. Those kinds of systems aren't especially debuggable (it's JTAG or nothing). I don't have any issue with getting that fixed too ... but unless someone has a platform that relies on that case (or can be made to do so, for testing), then it's hard for me to worry about it! - Dave > > Regards, > Andrew Victor > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/