Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754545AbYJ1WDd (ORCPT ); Tue, 28 Oct 2008 18:03:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753271AbYJ1WDX (ORCPT ); Tue, 28 Oct 2008 18:03:23 -0400 Received: from sj-iport-6.cisco.com ([171.71.176.117]:40294 "EHLO sj-iport-6.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753084AbYJ1WDW (ORCPT ); Tue, 28 Oct 2008 18:03:22 -0400 X-IronPort-AV: E=Sophos;i="4.33,501,1220227200"; d="scan'208";a="184346028" From: Roland Dreier To: Arjan van de Ven Cc: Avi Kivity , Glauber Costa , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, aliguori@codemonkey.ws, npiggin@suse.de, Jeremy Fitzhardinge , Krzysztof Helt Subject: Re: [PATCH] regression: vmalloc easily fail. References: <1225234513-3996-1-git-send-email-glommer@redhat.com> <49077E1A.5080105@redhat.com> <20081028144255.05712d70@infradead.org> X-Message-Flag: Warning: May contain useful information Date: Tue, 28 Oct 2008 15:03:20 -0700 In-Reply-To: <20081028144255.05712d70@infradead.org> (Arjan van de Ven's message of "Tue, 28 Oct 2008 14:42:55 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OriginalArrivalTime: 28 Oct 2008 22:03:20.0590 (UTC) FILETIME=[FD3E0AE0:01C93948] Authentication-Results: sj-dkim-4; header.From=rdreier@cisco.com; dkim=pass ( sig from cisco.com/sjdkim4002 verified; ); Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 461 Lines: 10 > I suspect it's a case of off-by-one... ALIGN() might round down, and > the "+ (PAGE_SIZE-1)" was there to make it round up. > Except for that missing -1 ... ALIGN() has always rounded up, at least back to 2.4. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/