Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754733AbYJ1WDq (ORCPT ); Tue, 28 Oct 2008 18:03:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754323AbYJ1WDa (ORCPT ); Tue, 28 Oct 2008 18:03:30 -0400 Received: from mail.crca.org.au ([67.207.131.56]:33578 "EHLO crca.org.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754267AbYJ1WD3 (ORCPT ); Tue, 28 Oct 2008 18:03:29 -0400 X-Bogosity: Ham, spamicity=0.000000 Subject: Re: [linux-pm] Freezer: Don't count threads waiting for frozen filesystems. From: Nigel Cunningham To: Miklos Szeredi Cc: rjw@sisk.pl, linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org In-Reply-To: References: <1224886068.6478.21.camel@nigel-laptop> <1225106427.26724.5.camel@nigel-laptop> <200810271237.40049.rjw@sisk.pl> <1225107607.26724.9.camel@nigel-laptop> <1225141168.26724.23.camel@nigel-laptop> <1225145607.26724.54.camel@nigel-laptop> <1225229399.9661.13.camel@nigel-laptop> Content-Type: text/plain Organization: Christian Reformed Churches of Australia Date: Wed, 29 Oct 2008 09:03:25 +1100 Message-Id: <1225231405.9661.18.camel@nigel-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 28 Hi. On Tue, 2008-10-28 at 22:51 +0100, Miklos Szeredi wrote: > On Wed, 29 Oct 2008, Nigel Cunningham wrote: > > > However it does not fix the freezing of tasks which are waiting for > > > VFS locks (i.e. inode->i_mutex) held by the outstanding fuse requests. > > > This is the tricky part... > > > > Convert them all to wait_event_freezeable. > > You mean convert mutexes to event queues? Not a very good idea. No, I don't. Sorry. I was thinking you were referring to the wait_event calls in the fuse request code. My bad. Perhaps it's best to go back to my original position: hold new requests and allow existing ones to complete. I'll look again at previous messages to see why you thought that was problematic. Regards, Nigel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/