Return-Path: <linux-kernel-owner+w=401wt.eu-S1754466AbYJ2OtV@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754466AbYJ2OtV (ORCPT <rfc822;w@1wt.eu>);
	Wed, 29 Oct 2008 10:49:21 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753522AbYJ2OtI
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 29 Oct 2008 10:49:08 -0400
Received: from ug-out-1314.google.com ([66.249.92.170]:32039 "EHLO
	ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753492AbYJ2OtH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 29 Oct 2008 10:49:07 -0400
Message-ID: <ac3eb2510810290749o2dd062b5m7b966d2d25b69714@mail.gmail.com>
Date: Wed, 29 Oct 2008 15:49:05 +0100
From: "Kay Sievers" <kay.sievers@vrfy.org>
To: "Folkert van Heusden" <folkert@vanheusden.com>,
       "Peter Zijlstra" <a.p.zijlstra@chello.nl>
Subject: Re: [2.6.26] kobject_add_internal failed for 2:0 with -EEXIST / unable to handle kernel NULL pointer dereference in sysfs_create_link
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <20081029132704.GS11214@vanheusden.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20081028151157.GI11214@vanheusden.com>
	 <ac3eb2510810281607o19266977l4c77d3d3ab4bb849@mail.gmail.com>
	 <20081029094041.GO11214@vanheusden.com>
	 <ac3eb2510810290525h1579bad8i4836ce1291d9022@mail.gmail.com>
	 <20081029132704.GS11214@vanheusden.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2022
Lines: 45

On Wed, Oct 29, 2008 at 14:27, Folkert van Heusden
<folkert@vanheusden.com> wrote:
>> >> > While running my http://vanheusden.com/pyk/ script (which randomly
>> >> > inserts and removes modules) I triggered the folllowing oops in a 2.6.26
>> >> > kernel on an IBM xSeries 260. This oops (in fact no oops at all) did not
>> >> > get triggered in a 2.6.18 kernel on that system.
>> >> >
>> >> > [   42.507375] FDC 0 is a National Semiconductor PC87306
>> >> > [   42.509057] kobject_add_internal failed for 2:0 with -EEXIST, don't try to register things with the same name in the same directory.
>> >> > [   42.509291] Pid: 5301, comm: modprobe Not tainted 2.6.26-1-amd64 #1
>> >> > [   42.509431]
>> >> > [   42.509433] Call Trace:
>> >> > [   42.509685]  [<ffffffff8031b031>] kobject_add_internal+0x13f/0x17e
> ...
>> >> > [   42.511519]  [<ffffffff8027d23b>] bdi_register+0x57/0xb4
>> >>
>> >> Looks like bdi sees two devices with the same devnum, or didn't
>> >> cleanup an old entry. What does: ls -l "/sys/class/bdi/" print?
>> >
>> > The following:
>> > folkert@debiantesthw:~$ ls -l /sys/class/bdi/
>> > drwxr-xr-x 3 root root 0 2008-10-28 18:32 2:0
>> > drwxr-xr-x 3 root root 0 2008-10-28 18:32 2:1
>>
>> Oh, you are running the old sysfs layout without symlinks. Care to
>> tell where the "device" link in these directories points to?
>
> None exist:
> folkert@debiantesthw:~$ ls -la /sys/class/bdi/*/device
> ls: cannot access /sys/class/bdi/*/device: No such file or directory

Ah, sorry. Seems the bdi stuff never got to pass the usual parent
device with the device registration, to let the bdi device show up at
the right place in the device tree.

Let's see what current devices on your box have the major 2:
  find /sys -name dev | xargs grep '^2:'

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/