Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754499AbYJ2OxA (ORCPT ); Wed, 29 Oct 2008 10:53:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753822AbYJ2Oww (ORCPT ); Wed, 29 Oct 2008 10:52:52 -0400 Received: from mx2.redhat.com ([66.187.237.31]:48702 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753821AbYJ2Oww (ORCPT ); Wed, 29 Oct 2008 10:52:52 -0400 Message-ID: <49087871.3010303@redhat.com> Date: Wed, 29 Oct 2008 10:51:29 -0400 From: Chris Snook Organization: Red Hat User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Huang Ying CC: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATH -mm -v2] Fix a race condtion of oops_in_progress References: <1225268796.24095.48.camel@yhuang-dev.sh.intel.com> In-Reply-To: <1225268796.24095.48.camel@yhuang-dev.sh.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 662 Lines: 15 Huang Ying wrote: > Fix a race condition accessing oops_in_progress. Which may be changed on > multiple CPU simultaneously, but it is changed via non-atomic operation > ++/--. This patch changes the definition of oops_in_process from int to > atomic_t, and accessing method to atomic operations. You also need barriers. I believe rmb() before atomic_read() and wmb() after atomic_set() should suffice. -- Chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/