Date: Wed, 29 Oct 2008 19:53:13 +0100
From: Sam Ravnborg <sam@ravnborg.org>
To: Jesper Nilsson <Jesper.Nilsson@axis.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
       Mikael Starvik <mikael.starvik@axis.com>
Subject: Re: [PATCH] [CRIS] Move header files from include to arch/cris/include.
Message-ID: <20081029185313.GA22105@uranus.ravnborg.org>
References: <20081021164211.GG24715@axis.com> <20081029173420.GM4608@axis.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081029173420.GM4608@axis.com>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1987
Lines: 53

On Wed, Oct 29, 2008 at 06:34:20PM +0100, Jesper Nilsson wrote:
> On Tue, Oct 21, 2008 at 06:42:11PM +0200, Jesper Nilsson wrote:
> > Hi,
> > 
> > I'm looking for some feedback on the changes in the branch include_move
> > at the git-tree:
> > 
> >         git://repo.or.cz/cris-mirror.git include_move
> > 
> > I've performed the move of the CRIS headers using the ARM and Blackfin
> > ports as a pattern.
> > 
> > That means that the machine dependent header files are moved to
> > arch/cris/mach-{fs,a3}/include, while the common and architecture
> > dependent files are moved to arch/cris/include.
> > 
> > It is mainly this I'd like some input on, since most other ports
> > that have moved their header files have put all headers in arch/*/include.
> 
> After some soul-searching I've changed this, and moved all header
> files into arch/cris/include. The most telling argument was that
> the CRIS port wouldn't have anything other than include files in
> the arch/cris/mach-* directories.
> 
> If that changes some time in the future, it is a simple operation
> moving the machine dependent header files there.
> 
> Since the complete patch is too large to post, I'm not including
> the diff of the files moved, only the files changed.

Hi Jesper.

I have looked at the diffstat and the patches and this is a
great improvement in readability of the cris stuff.

It would be good to get this in mainline as fast as possible.
Can I ask you to prepare to git trees to pull from and ask
Linus to pull it.
First tree should be the header move only and if you can
convince him it would be great to take the next two patches
so add them to another tree.

You can add an:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

on all three patches.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/