Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755144AbYJ2UX4 (ORCPT ); Wed, 29 Oct 2008 16:23:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754576AbYJ2UXj (ORCPT ); Wed, 29 Oct 2008 16:23:39 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:45661 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754452AbYJ2UXi (ORCPT ); Wed, 29 Oct 2008 16:23:38 -0400 Date: Wed, 29 Oct 2008 16:23:34 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Adrian Bunk cc: Sam Ravnborg , LKML , Ingo Molnar , Frederic Weisbecker , Abhishek Sagar , "David S. Miller" , Thomas Gleixner , Peter Zijlstra , Andrew Morton , Linus Torvalds , Steven Rostedt Subject: Re: [PATCH 01/11] ftrace: handle generic arch calls In-Reply-To: <20081029201646.GA1816@cs181140183.pp.htv.fi> Message-ID: References: <20081022184313.179487464@goodmis.org> <20081022185135.618026303@goodmis.org> <20081029190045.GC22105@uranus.ravnborg.org> <20081029194956.GA22606@uranus.ravnborg.org> <20081029201646.GA1816@cs181140183.pp.htv.fi> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 895 Lines: 21 On Wed, 29 Oct 2008, Adrian Bunk wrote: > > > > > > Since x86 is the ambiguous case, I made it the one that would be converted > > > to i386 or x86_64 since those could be passed in directly. > > The trick is usually to replace use of ARCH with SRCARCH. > > That won't help - what he wants to know is whether he's on 32bit or > on 64bit. I will still get the "bits" parameter. The issue that we are talking about here is that I have this ugly if statement that deals with the fact that we can get "x86", "x86_64" or "i386" passed in as the ARCH. I'm guessing if we switch ARCH to SRCARCH then we can just test against x86 and bits? -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/