Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754751AbYJ2UdA (ORCPT ); Wed, 29 Oct 2008 16:33:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751070AbYJ2Ucw (ORCPT ); Wed, 29 Oct 2008 16:32:52 -0400 Received: from smtp5.pp.htv.fi ([213.243.153.39]:41660 "EHLO smtp5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750732AbYJ2Ucv (ORCPT ); Wed, 29 Oct 2008 16:32:51 -0400 Date: Wed, 29 Oct 2008 22:31:33 +0200 From: Adrian Bunk To: Steven Rostedt Cc: Sam Ravnborg , LKML , Ingo Molnar , Frederic Weisbecker , Abhishek Sagar , "David S. Miller" , Thomas Gleixner , Peter Zijlstra , Andrew Morton , Linus Torvalds , Steven Rostedt Subject: Re: [PATCH 01/11] ftrace: handle generic arch calls Message-ID: <20081029203133.GC1816@cs181140183.pp.htv.fi> References: <20081022184313.179487464@goodmis.org> <20081022185135.618026303@goodmis.org> <20081029190045.GC22105@uranus.ravnborg.org> <20081029194956.GA22606@uranus.ravnborg.org> <20081029201646.GA1816@cs181140183.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1396 Lines: 42 On Wed, Oct 29, 2008 at 04:23:34PM -0400, Steven Rostedt wrote: > > On Wed, 29 Oct 2008, Adrian Bunk wrote: > > > > > > > > Since x86 is the ambiguous case, I made it the one that would be converted > > > > to i386 or x86_64 since those could be passed in directly. > > > The trick is usually to replace use of ARCH with SRCARCH. > > > > That won't help - what he wants to know is whether he's on 32bit or > > on 64bit. > > I will still get the "bits" parameter. Ah, I didn't get this bit from your email. > The issue that we are talking about > here is that I have this ugly if statement that deals with the fact that > we can get "x86", "x86_64" or "i386" passed in as the ARCH. I'm guessing > if we switch ARCH to SRCARCH then we can just test against x86 and bits? Yes. And as a bonus you will automatically get the correct output when you'll add support for UML. > -- Steve cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/