Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755361AbYJ2VoH (ORCPT ); Wed, 29 Oct 2008 17:44:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754231AbYJ2Vnt (ORCPT ); Wed, 29 Oct 2008 17:43:49 -0400 Received: from qw-out-2122.google.com ([74.125.92.27]:29080 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754144AbYJ2Vnt (ORCPT ); Wed, 29 Oct 2008 17:43:49 -0400 Message-ID: <4908D912.8010003@genesi-usa.com> Date: Wed, 29 Oct 2008 16:43:46 -0500 From: Matt Sealey User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: Scott Wood , Stephen Hemminger , netdev@vger.kernel.org, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC v2] net: add PCINet driver References: <20081029202027.GH12879@ovro.caltech.edu> <20081029132506.55b93555@extreme> <20081029205002.GI12879@ovro.caltech.edu> <4908CD96.300@freescale.com> <20081029211312.GJ12879@ovro.caltech.edu> In-Reply-To: <20081029211312.GJ12879@ovro.caltech.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 659 Lines: 19 Ira Snyder wrote: > > I'll go ahead change the typedef to a struct. Hopefully some of the > other inspiration I took wasn't too bad. I'm totally open to suggestions > on improvements for this driver. Not a suggestion for improvement, but I have to say this is by far the single coolest thing I have EVER seen submitted to mainline :) -- Matt Sealey Genesi, Manager, Developer Relations -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/