Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753561AbYJ3Gqb (ORCPT ); Thu, 30 Oct 2008 02:46:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753266AbYJ3GqO (ORCPT ); Thu, 30 Oct 2008 02:46:14 -0400 Received: from mx1.suse.de ([195.135.220.2]:42961 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753177AbYJ3GqN (ORCPT ); Thu, 30 Oct 2008 02:46:13 -0400 Date: Thu, 30 Oct 2008 07:46:11 +0100 Message-ID: From: Takashi Iwai To: Kay Sievers Cc: linux-kernel , Greg KH Subject: Re: sound: struct device - replace bus_id with dev_name(), dev_set_name() In-Reply-To: <1225330040.5970.83.camel@nga.site> References: <1225330040.5970.83.camel@nga.site> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2550 Lines: 67 At Thu, 30 Oct 2008 02:27:20 +0100, Kay Sievers wrote: > > This patch is part of a larger patch series which will remove > the "char bus_id[20]" name string from struct device. The device > name is managed in the kobject anyway, and without any size > limitation, and just needlessly copied into "struct device". > > To set and read the device name dev_name(dev) and dev_set_name(dev) > must be used. If your code uses static kobjects, which it shouldn't > do, "const char *init_name" can be used to statically provide the > name the registered device should have. At registration time, the > init_name field is cleared, to enforce the use of dev_name(dev) to > access the device name at a later time. > > We need to get rid of all occurrences of bus_id in the entire tree > to be able to enable the new interface. Please apply this patch, > and possibly convert any remaining remaining occurrences of bus_id. > > We want to submit a patch to -next, which will remove bus_id from > "struct device", to find the remaining pieces to convert, and finally > switch over to the new api, which will remove the 20 bytes array > and does no longer have a size limitation. > > Thanks, > Kay > > > From: Kay Sievers > Subject: sound: struct device - replace bus_id with dev_name(), dev_set_name() > > CC: Takashi Iwai > Acked-by: Greg Kroah-Hartman > Signed-Off-By: Kay Sievers Thanks, applied now to sound tree. Takashi > --- > > > diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c > index 6704acb..bd510ec 100644 > --- a/sound/pci/ac97/ac97_codec.c > +++ b/sound/pci/ac97/ac97_codec.c > @@ -1927,9 +1927,9 @@ static int snd_ac97_dev_register(struct snd_device *device) > ac97->dev.bus = &ac97_bus_type; > ac97->dev.parent = ac97->bus->card->dev; > ac97->dev.release = ac97_device_release; > - snprintf(ac97->dev.bus_id, BUS_ID_SIZE, "%d-%d:%s", > - ac97->bus->card->number, ac97->num, > - snd_ac97_get_short_name(ac97)); > + dev_set_name(&ac97->dev, "%d-%d:%s", > + ac97->bus->card->number, ac97->num, > + snd_ac97_get_short_name(ac97)); > if ((err = device_register(&ac97->dev)) < 0) { > snd_printk(KERN_ERR "Can't register ac97 bus\n"); > ac97->dev.bus = NULL; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/