Date: Thu, 30 Oct 2008 00:04:42 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: "Ray Lee" <ray-lk@madrabbit.org>
Cc: "Arjan van de Ven" <arjan@infradead.org>,
       "Marcin Slusarz" <marcin.slusarz@gmail.com>,
       "Carlos R. Mafra" <crmafra2@gmail.com>,
       "Arjan van de Ven" <arjan@linux.intel.com>,
       linux-kernel@vger.kernel.org
Subject: Re: [2.6.28-rc1 regression] wmifinfo dockapp takes 100% of cpu
 (bisected)
Message-Id: <20081030000442.fdc831c1.akpm@linux-foundation.org>
In-Reply-To: <2c0942db0810251238u7eae212ct76af5c6d05126260@mail.gmail.com>
References: <20081025094043.GA4438@localhost.aei.mpg.de>
	<490327B6.2090903@linux.intel.com>
	<20081025071348.63c426d9@infradead.org>
	<20081025162503.GA4001@localhost.aei.mpg.de>
	<20081025180322.GA10932@joi>
	<20081025121244.07cdd6d7@infradead.org>
	<2c0942db0810251238u7eae212ct76af5c6d05126260@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1453
Lines: 34

On Sat, 25 Oct 2008 12:38:22 -0700 "Ray Lee" <ray-lk@madrabbit.org> wrote:

> On Sat, Oct 25, 2008 at 12:12 PM, Arjan van de Ven <arjan@infradead.org> wrote:
> > On Sat, 25 Oct 2008 20:03:27 +0200
> > Marcin Slusarz <marcin.slusarz@gmail.com> wrote:
> >> > >           if (copy_from_user(&tv, tvp, sizeof(tv)))
> >> > >                   return -EFAULT;
> >> > >
> >> > > +         while (tv.tv_usec > USEC_PER_SEC && i < 1000) {
> >>                                   ^
> >> should be >=
> >
> > yeah thanks for catching that. Note to self: don't code before coffee
> >
> > I'm not very happy with a while loop; but at least it solves the problem
> >
> > I'll try to make it nicer than this ...
> 
> Regardless, you may wish to make a set_normalized_timeval and place it
> in kernel/time.c right after the current set_nromalized_timespec.

Yes, this comes up fairly regularly and we would benefit from having a
normalize-a-timeval library function.

I don't think it should be implemented via a while loop though.  That's
acceptable with timespecs, which can only loop four or so times.  But
timevals use microseconds and can loop thousands of times and hence a
normalization function should use division.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/