Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754725AbYJ3JKS (ORCPT ); Thu, 30 Oct 2008 05:10:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753271AbYJ3JKG (ORCPT ); Thu, 30 Oct 2008 05:10:06 -0400 Received: from server.drzeus.cx ([85.8.24.28]:34167 "EHLO smtp.drzeus.cx" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753092AbYJ3JKF (ORCPT ); Thu, 30 Oct 2008 05:10:05 -0400 Date: Thu, 30 Oct 2008 10:09:57 +0100 From: Pierre Ossman To: Harvey Harrison Cc: Kay Sievers , linux-kernel , Greg KH Subject: Re: mmc: struct device - replace bus_id with dev_name(), dev_set_name() Message-ID: <20081030100957.6cba7174@mjolnir.drzeus.cx> In-Reply-To: <1225331284.5496.12.camel@brick> References: <1225329600.5970.72.camel@nga.site> <1225331284.5496.12.camel@brick> X-Mailer: Claws Mail 3.6.0 (GTK+ 2.14.4; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=PGP-SHA1; boundary="=_freyr.drzeus.cx-9841-1225357802-0001-2" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1739 Lines: 53 This is a MIME-formatted message. If you see this text it means that your E-mail software does not support MIME-formatted messages. --=_freyr.drzeus.cx-9841-1225357802-0001-2 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 29 Oct 2008 18:48:04 -0700 Harvey Harrison wrote: >=20 > A lot of these helpers don't seem to add that much, would you care for > a patch removing them Pierre? >=20 > Specifically sdio_func_id, sdio_get/set_drvdata don't have that many > users. >=20 > mmc_hostname has a lot of users, but if you're agreeable, I could > take a crack at that too. >=20 As Marcel said, they provide a nice abstraction (even if it is indeed a bit silly to have wrappers around wrappers around ..). It also tends to make the code a bit more readable. Rgds --=20 -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption. --=_freyr.drzeus.cx-9841-1225357802-0001-2 Content-Type: application/pgp-signature; name="signature.asc" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAkkJeeoACgkQ7b8eESbyJLgGNQCfY5qXOUxoFV9Qkh3+gAFWIqCH i50An2K8CSccZvm1d9YDMPi+EMDZbXXn =LwTp -----END PGP SIGNATURE----- --=_freyr.drzeus.cx-9841-1225357802-0001-2-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/