Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754665AbYJ3Jvr (ORCPT ); Thu, 30 Oct 2008 05:51:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753411AbYJ3Jvh (ORCPT ); Thu, 30 Oct 2008 05:51:37 -0400 Received: from hera.kernel.org ([140.211.167.34]:33737 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752136AbYJ3Jvg (ORCPT ); Thu, 30 Oct 2008 05:51:36 -0400 Message-ID: <4909839D.1020508@kernel.org> Date: Thu, 30 Oct 2008 18:51:25 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.12 (X11/20071114) MIME-Version: 1.0 To: Mike Anderson CC: Jens Axboe , James Bottomley , linux-scsi , Linux Kernel , IDE/ATA development list Subject: Re: [PATCH] block: add timer on blkdev_dequeue_request() not elv_next_request() References: <490927CD.2010205@kernel.org> <20081030072956.GL31673@kernel.dk> <49096865.2050006@kernel.org> <20081030075855.GO31673@kernel.dk> <20081030092741.GA9478@linux.vnet.ibm.com> In-Reply-To: <20081030092741.GA9478@linux.vnet.ibm.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Thu, 30 Oct 2008 09:51:30 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 24 Mike Anderson wrote: > From: Mike Anderson > Date: Thu, 30 Oct 2008 02:16:20 -0700 > Subject: [PATCH 1/1] blk: move blk_delete_timer call in end_that_request_last > > Move the calling blk_delete_timer to later in end_that_request_last to > address an issue where blkdev_dequeue_request may have add a timer for the > request. > > Signed-off-by: Mike Anderson This patch definitely is necessary. Acked-by: Tejun Heo Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/