Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754688AbYJ3Lki (ORCPT ); Thu, 30 Oct 2008 07:40:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753421AbYJ3Lka (ORCPT ); Thu, 30 Oct 2008 07:40:30 -0400 Received: from ns2.suse.de ([195.135.220.15]:42496 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753324AbYJ3Lk3 (ORCPT ); Thu, 30 Oct 2008 07:40:29 -0400 Date: Thu, 30 Oct 2008 12:40:28 +0100 Message-ID: From: Takashi Iwai To: "=?ISO-8859-1?Q?Ilpo_J=E4rvinen?=" Cc: perex@perex.cz, LKML , Andrew Morton Subject: Re: [PATCH 01/10] sound/ice1712: indentation & braces disagree - add braces In-Reply-To: References: User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1710 Lines: 62 At Thu, 30 Oct 2008 13:09:55 +0200 (EET), =?ISO-8859-1?Q?Ilpo_J=E4rvinen?= wrote: > > Neither has any significance currently to the flow > because err is checked for the same condition before > the place of disagreement. > > Signed-off-by: Ilpo J?rvinen Doh, that must come from the last coding-style fix patch. Applied now and will be in the next pull request. Thanks! Takashi > --- > sound/pci/ice1712/ice1712.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c > index 5b44238..58d7cda 100644 > --- a/sound/pci/ice1712/ice1712.c > +++ b/sound/pci/ice1712/ice1712.c > @@ -2688,12 +2688,13 @@ static int __devinit snd_ice1712_probe(struct pci_dev *pci, > return err; > } > > - if (ice_has_con_ac97(ice)) > + if (ice_has_con_ac97(ice)) { > err = snd_ice1712_pcm(ice, pcm_dev++, NULL); > if (err < 0) { > snd_card_free(card); > return err; > } > + } > > err = snd_ice1712_ac97_mixer(ice); > if (err < 0) { > @@ -2715,12 +2716,13 @@ static int __devinit snd_ice1712_probe(struct pci_dev *pci, > } > } > > - if (ice_has_con_ac97(ice)) > + if (ice_has_con_ac97(ice)) { > err = snd_ice1712_pcm_ds(ice, pcm_dev++, NULL); > if (err < 0) { > snd_card_free(card); > return err; > } > + } > > if (!c->no_mpu401) { > err = snd_mpu401_uart_new(card, 0, MPU401_HW_ICE1712, > -- > 1.5.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/