Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756822AbYJ3RB1 (ORCPT ); Thu, 30 Oct 2008 13:01:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754600AbYJ3RBU (ORCPT ); Thu, 30 Oct 2008 13:01:20 -0400 Received: from gv-out-0910.google.com ([216.239.58.186]:43139 "EHLO gv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753746AbYJ3RBT (ORCPT ); Thu, 30 Oct 2008 13:01:19 -0400 Subject: hid: struct device - replace bus_id with dev_name(), dev_set_name() From: Kay Sievers To: Jiri Kosina Cc: linux-kernel , Greg KH Content-Type: text/plain Date: Thu, 30 Oct 2008 17:55:05 +0100 Message-Id: <1225385705.21973.20.camel@nga.site> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2200 Lines: 57 This patch is part of a larger patch series which will remove the "char bus_id[20]" name string from struct device. The device name is managed in the kobject anyway, and without any size limitation, and just needlessly copied into "struct device". To set and read the device name dev_name(dev) and dev_set_name(dev) must be used. If your code uses static kobjects, which it shouldn't do, "const char *init_name" can be used to statically provide the name the registered device should have. At registration time, the init_name field is cleared, to enforce the use of dev_name(dev) to access the device name at a later time. We need to get rid of all occurrences of bus_id in the entire tree to be able to enable the new interface. Please apply this patch, and possibly convert any remaining remaining occurrences of bus_id. We want to submit a patch to -next, which will remove bus_id from "struct device", to find the remaining pieces to convert, and finally switch over to the new api, which will remove the 20 bytes array and does no longer have a size limitation. Thanks, Kay From: Kay Sievers Subject: hid: struct device - replace bus_id with dev_name(), dev_set_name() CC: Jiri Kosina Acked-by: Greg Kroah-Hartman Signed-Off-By: Kay Sievers --- diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 721a36d..73ccc37 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1573,9 +1573,8 @@ int hid_add_device(struct hid_device *hdev) if (hid_ignore(hdev)) return -ENODEV; - /* XXX hack, any other cleaner solution < 20 bus_id bytes? */ - sprintf(hdev->dev.bus_id, "%04X:%04X:%04X.%04X", hdev->bus, - hdev->vendor, hdev->product, atomic_inc_return(&id)); + dev_set_name(&hdev->dev, "%04X:%04X:%04X.%04X", hdev->bus, + hdev->vendor, hdev->product, atomic_inc_return(&id)); ret = device_add(&hdev->dev); if (!ret) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/