Date: Thu, 30 Oct 2008 18:58:44 +0100
From: =?utf-8?B?SsO2cm4=?= Engel <joern@logfs.org>
To: Pavel Machek <pavel@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] B+Tree library
Message-ID: <20081030175844.GC7157@logfs.org>
References: <20081026124643.GA1328@logfs.org> <20081030174300.GA1773@ucw.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20081030174300.GA1773@ucw.cz>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1415
Lines: 37

On Thu, 30 October 2008 18:43:00 +0100, Pavel Machek wrote:
> 
> + * Disks have fulfilled the prerequite for a long time.  More recently DRAM
> 
> prerequisite?

In the paragraph above:

+ * B+Trees can be used similar to Linux radix trees (which don't have anything
+ * in common with textbook radix trees, beware).  Prerequisite for them working
+ * well is that access to a random tree node is much faster than a large number
+ * of operations within each node.

> +#define MAX(a, b) ((a) > (b) ? (a) : (b))
> 
> We already have that in the headers somewhere.

Except that min/max in include/linux/kernel.h have some type-safety
added.  In this particular case that is actually a disadvantage:
  CC      lib/btree.o
  lib/btree.c:56: error: braced-group within expression allowed only inside a function
  lib/btree.c:62: error: braced-group within expression allowed only inside a function
  lib/btree.c:67: error: braced-group within expression allowed only inside a function

So I need something more stupid. :)

Jörn

-- 
It does not require a majority to prevail, but rather an irate,
tireless minority keen to set brush fires in people's minds.
-- Samuel Adams
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/