Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758845AbYJ3Skm (ORCPT ); Thu, 30 Oct 2008 14:40:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755582AbYJ3Skb (ORCPT ); Thu, 30 Oct 2008 14:40:31 -0400 Received: from matrixpower.ru ([195.178.208.66]:56683 "EHLO tservice.net.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754993AbYJ3Ska (ORCPT ); Thu, 30 Oct 2008 14:40:30 -0400 Date: Thu, 30 Oct 2008 21:40:24 +0300 From: Evgeniy Polyakov To: Stephen Hemminger Cc: "Rafael J. Wysocki" , Ingo Molnar , Evgeniy Polyakov , Peter Zijlstra , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, David Miller , Mike Galbraith , Andrew Morton Subject: Re: [tbench regression fixes]: digging out smelly deadmen. Message-ID: <20081030184024.GA6314@ioremap.net> References: <20081009231759.GA8664@tservice.net.ru> <20081010115518.GA3159@tservice.net.ru> <20081010115725.GD19487@elte.hu> <200810250025.35734.rjw@sisk.pl> <20081026112924.GA29258@ioremap.net> <20081026122300.GA30905@ioremap.net> <20081030111526.7d9bb0f8@extreme> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081030111526.7d9bb0f8@extreme> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 982 Lines: 20 On Thu, Oct 30, 2008 at 11:15:26AM -0700, Stephen Hemminger (shemminger@vyatta.com) wrote: > Has anyone looked into the impact of port randomization on this benchmark. > If it is generating lots of sockets quickly there could be an impact: > * port randomization causes available port space to get filled non-uniformly > and what was once a linear scan may have to walk over existing ports. > (This could be improved by a hint bitmap) > > * port randomization adds at least one modulus operation per socket > creation. This could be optimized by using a loop instead. In this benchmark only two sockets are created per client for the whole run, so this should not have any impact on performance. -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/