DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=murjOK9iMgMrZCK2l/hTE3NSkptnW/WFmM9O5BY3YAVsBoweXhz87rFNIgtoBoNdxDJDaxPFLslIp4WJKs+7l9ga11HHDpkK9CoBubK5l9eeMiTvE56aQa/UPDA7n4fsmqhGULDgVZ9hWF2HYI16QUCu509x7eVE+WKYuL3EReI=  ;
From: David Brownell <david-b@pacbell.net>
To: Nate Case <ncase@xes-inc.com>
Subject: Re: [PATCH] rtc-ds1307: Reset bogus register values on m41t00
Date: Thu, 30 Oct 2008 15:11:18 -0700
User-Agent: KMail/1.9.10
Cc: linux-kernel@vger.kernel.org
References: <1225301377-9092-1-git-send-email-ncase@xes-inc.com> <1225398691.27415.170.camel@localhost.localdomain> <1225402486.27415.177.camel@localhost.localdomain>
In-Reply-To: <1225402486.27415.177.camel@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200810301511.18307.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1033
Lines: 26

On Thursday 30 October 2008, Nate Case wrote:
> On Thu, 2008-10-30 at 15:31 -0500, Nate Case wrote:
> > I'll go ahead and re-spin the patch.
> 
> After thinking about this more, I'm not sure it's right to do anything
> more than the "remove legacy probe checks" patch already does.  Can you
> think of any harm in having the oscillator running with bogus register
> values? 

Not really.  If you're content with that patch, I won't worry
any more.


> Calls to get_time() will return -EINVAL, but that seems to be 
> the norm for any "bad time" condition.  It makes me think that resetting
> to a sane time is putting more policy than desired in the driver.

That's a very defensible position.  It does mean you'll want
your userspace to defend against that, but that's not hard.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/