Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752759AbYJaOSY (ORCPT ); Fri, 31 Oct 2008 10:18:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751391AbYJaOSQ (ORCPT ); Fri, 31 Oct 2008 10:18:16 -0400 Received: from pasmtpb.tele.dk ([80.160.77.98]:46886 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751350AbYJaOSQ (ORCPT ); Fri, 31 Oct 2008 10:18:16 -0400 Date: Fri, 31 Oct 2008 15:17:02 +0100 From: Jens Axboe To: "Martin K. Petersen" Cc: device-mapper development , Kiyoshi Ueda , linux-kernel@vger.kernel.org, Alasdair G Kergon Subject: Re: [dm-devel] [PATCH] Add gfp_mask to bio_integrity_clone() Message-ID: <20081031141701.GI31673@kernel.dk> References: <490942D4.3070504@ce.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1064 Lines: 27 On Fri, Oct 31 2008, Martin K. Petersen wrote: > >>>>> "Jun'ichi" == Jun'ichi Nomura writes: > > Jun'ichi> What do you think about adding gfp_mask parameter to > Jun'ichi> bio_integrity_clone() like the attached patch? > > Jun'ichi> It also seems natural to inherit gfp_mask from bio_clone > Jun'ichi> when bio_integrity_clone is called from it. Since > Jun'ichi> bio_clone() is the only caller of bio_integrity_clone() in > Jun'ichi> 2.6.28-rc2 and all in-tree callers of bio_clone() are using > Jun'ichi> GFP_NOIO, the patch does nothing other than changing the > Jun'ichi> interface. > > Looks good to me. I'll update the non-multipath DM bits accordingly. > > Acked-by: Martin K. Petersen Shall I just include this in the 2.6.29 branch? -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/