Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752476AbYJaRJ0 (ORCPT ); Fri, 31 Oct 2008 13:09:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751279AbYJaRJS (ORCPT ); Fri, 31 Oct 2008 13:09:18 -0400 Received: from ey-out-2122.google.com ([74.125.78.26]:11371 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbYJaRJR (ORCPT ); Fri, 31 Oct 2008 13:09:17 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding:sender; b=V7WumxQofJkmiPC/Ers8QeVeYDsDRLU5hRsV0Um7ZWERbzFWflw2WYjvyqUOOAJKMq Nzu3R5V66cft51rAJ2k47tuszKe6T4MvcghHU0zpOeqyB7/UzmhyOK4mjayQl5ckHTSn BL4/IDtqT+itDaxSjN8j9/TSU05BtZlUaDb1g= Message-ID: <490B3BB5.8060801@tuffmail.co.uk> Date: Fri, 31 Oct 2008 17:09:09 +0000 From: Alan Jenkins User-Agent: Thunderbird 2.0.0.17 (X11/20080925) MIME-Version: 1.0 To: Matthew Garrett CC: linux-kernel , linux acpi Subject: eeepc-laptop rfkill, stupid question #4 and 5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 769 Lines: 18 Did you miss a call to rfkill_force_state() on resume? I can hibernate, then interrupt the boot with F2 to get into the BIOS, change the "Enable WLAN" setting, and continue the resume. When the eeepc-laptop driver resumes, it restores the pre-hibernation value. Actually, normal boot doesn't preserve the setting either. Your commit changes the behaviour from the rfkill state being persistent across reboot / power off (as a bios setting), to being always enabled on boot. It seems like a bad idea to me. Thanks Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/