Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752681AbYKAKRO (ORCPT ); Sat, 1 Nov 2008 06:17:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751381AbYKAKQ6 (ORCPT ); Sat, 1 Nov 2008 06:16:58 -0400 Received: from monty.telenet-ops.be ([195.130.132.56]:35896 "EHLO monty.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310AbYKAKQ5 (ORCPT ); Sat, 1 Nov 2008 06:16:57 -0400 Date: Sat, 1 Nov 2008 11:16:52 +0100 (CET) From: Geert Uytterhoeven To: Ingo Molnar cc: Alexey Dobriyan , Frederic Weisbecker , Stephen Rothwell , linux-next@vger.kernel.org, Linux Kernel Development , Steven Rostedt , Linux/m68k Subject: Re: [PATCH] tracing: fix a build error on alpha and m68k In-Reply-To: <20081031095544.GI30317@elte.hu> Message-ID: References: <49008D12.5090204@gmail.com> <4900B414.7090002@gmail.com> <20081023163433.GA3160@x200.localdomain> <20081030214910.GA14679@x200.localdomain> <20081031095544.GI30317@elte.hu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1760 Lines: 43 On Fri, 31 Oct 2008, Ingo Molnar wrote: > * Geert Uytterhoeven wrote: > > On Fri, 31 Oct 2008, Alexey Dobriyan wrote: > > > On Thu, Oct 23, 2008 at 08:34:33PM +0400, Alexey Dobriyan wrote: > > > > On Thu, Oct 23, 2008 at 07:27:48PM +0200, Frederic Weisbecker wrote: > > > > > When tracing is enabled, some arch have included > > > > > on their but others like alpha or m68k don't. > > > > > > > > > > Build error on alpha: > > > > > > > > > > kernel/trace/trace.c: In function 'tracing_generic_entry_update': > > > > > kernel/trace/trace.c:658: error: implicit declaration of function 'irqs_disabled_flags' > > > > > > FYI, this error still exists in mainline (7f82f000ed030d1108b4de47d9e2d556092980c6). > > > > Now it hit mainline (I can't be bothered to develop _new_ code to > > fix things in -next ;-), I'm implementing irqs_disabled_flags() for > > m68k. Stay tuned... > > this (now mainline) commit should have fixed it: > > 9244489: ftrace: handle archs that do not support irqs_disabled_flags > > can you still see problems? Yes, the "undefined reference to `save_stack_trace'", as already pointed out by Al. I'm trying his fix now... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/